Which is better Buffalo, NY or Brookville, New York?

Two odd choices you've got there. Since you say those are the only two places in NY that interest you, then what is your basis for concluding this if you don't yet know anything about their environments, weather, affordability, and recreational aspects? What exactly interests you about them then? Assuming the Brookville you like is the one on Long Island, it is completely different than Buffalo with about 300 miles distance between the two. If you're seriously planning a big move to another state, I'd recommend that you get better acquainted with it and not solely base your decision on what you've read online or browsed in a magazine. It's quite obvious with your two choices that you have a long way to go. IMO, they'd both be at the bottom of a very long list if I were moving here.