This is my code. Why does it have an error?
-
<?php if (!isset($_SESSION)) { session_start(); } ?> <?php require_once('../Connections/QUIZ.php'); ?> <!---------------------------------extra new update coding-----------------------------------------------------------------------------------------------------------> <?php echo $uid =$_GET['SchId']; $con = mysql_connect ("localhost","root"); // Select Database mysql_select_db("QUIZ", $con); // Specify the query to Insert Record if(isset($_POST['button'])) { echo "hiiii"; echo $Quiz=$_POST['cmbExam']; echo $Sem=$_POST['cmbSem']; echo $Subject=$_POST['cmbSubject']; echo $Date=$_POST['txtDate']; echo $Time=$_POST['txtTime']; echo "Hello"; echo $sql ="update quiz_schedule set `Schedule_Id` ='$uid',`Quiz_Name`='$QUIZ',`Semester`='$Sem',`Subject`='$Subject',`Date`='$Date',`Time`='Time' where `SchId`=`$uid`"; $result =mysql_query($sql); if($result) { echo("update"); } else { echo("not update"); } } ?> <!---------------------------------------------fetch----------------------------------------------------------------------------------> <?php // fetch the record all data........................ echo $uid =$_GET['SchId']; echo $sql = "SELECT * FROM quiz_schedule WHERE Schedule_Id='$uid'"; $result = mysql_query($sql); $row12 = mysql_fetch_array($result); //echo $Quiz=$row_Recordset1['Quiz_Name']; //echo $Quiz=$row['cmbExam']; echo $Id =$row12['Schedule_Id']; $Quiz =$row12['Quiz_Id']; $Sem=$row12['Semester']; $Subject_Id=$row12['Subject_Id']; echo $Date=$row12['QuizDate']; echo $Time=$row12['QuizTime']; ?> <!-- comment some time. <tr> <td class="style13"><div align="left" class="style9 style6"><strong><?php echo $Id;?></strong></div></td> <td class="style13"><div align="left" class="style9 style6"><strong><?php echo $Quiz;?></strong></div></td> <td class="style13"><div align="left" class="style9 style6"><strong><?php echo $Sem;?></strong></div></td> <td class="style13"><div align="left" class="style9 style6"><strong><?php echo $Subject;?></strong></div></td> <td class="style13"><div align="left" class="style9 style6"><strong><?php echo $Date;?></strong></div></td> <td class="style13"><div align="left" class="style9 style6"><strong><?php echo $Time;?></strong></div></td> </tr> -----> <?php // // Retrieve Number of records returned $records = mysql_num_rows($result); ?> <tr> <td colspan="7" class="style13"><div align="left" class="style12"> </div></td> </tr> <?php // Close the connection mysql_close($con); ?> </table> </div> </div> </div> <p> </p> <h1> </h1> </div> <div id="footerline"></div> </div> <div id="footer">Copyright © 2013 Online Quiz. All rights reserved.</div> </div> ' <!--------------------------end select the data all data--------------------------------> <!-----------------------------------------------------end extra new ------------------------------------------------------------------------------------------> <?php if (!function_exists("GetSQLValueString")) { function GetSQLValueString($theValue, $theType, $theDefinedValue = "", $theNotDefinedValue = "") { $theValue = get_magic_quotes_gpc() ? stripslashes($theValue) : $theValue; $theValue = function_exists("mysql_real_escape_string") ? mysql_real_escape_string($theValue) : mysql_escape_string($theValue); switch ($theType) { case "text": $theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL"; break; case "long": case "int": $theValue = ($theValue != "") ? intval($theValue) : "NULL"; break; case "double": $theValue = ($theValue != "") ? "'" . doubleval($theValue) . "'" : "NULL"; break; case "date": $theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL"; break; case "defined": $theValue = ($theValue != "") ? $theDefinedValue : $theNotDefinedValue; break; } return $theValue; } } mysql_select_db($database_QUIZ, $QUIZ); $query_Recordset1 = "SELECT * FROM quiz_category"; $Recordset1 = mysql_query($query_Recordset1, $QUIZ) or die(mysql_error()); $row_Recordset1 = mysql_fetch_assoc($Recordset1); $totalRows_Recordset1 = mysql_num_rows($Recordset1); mysql_select_db($database_QUIZ, $QUIZ); $query_Recordset2 = "SELECT * FROM subject_master"; $Recordset2 = mysql_query($query_Recordset2, $QUIZ) or die(mysql_error()); $row_Recordset2 = mysql_fetch_assoc($Recordset2); $totalRows_Recordset2 = mysql_num_rows($Recordset2); ?><!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html xmlns="http://www.w3.org/1999/xhtml"> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" /> <link href="style.css" rel="stylesheet" type="text/css" /> <title>QUIZ Management</title> <script src="../SpryAssets/SpryTabbedPanels.js" type="text/javascript"></script> <script src="../SpryAssets/SpryValidationTextField.js" type="text/javascript"></script> <link href="../SpryAssets/SpryTabbedPanels.css" rel="stylesheet" type="text/css" /> <style type="text/css"> <!-- .style1 { font-size: small; font-family: Verdana, Arial, Helvetica, sans-serif; } .style2 {font-family: Verdana, Arial, Helvetica, sans-serif} .style3 {font-size: small} --> </style> <link href="../SpryAssets/SpryValidationTextField.css" rel="stylesheet" type="text/css" /> <style type="text/css"> <!-- .style12 {font-size: small; font-weight: bold; } .style13 {font-family: Verdana, Arial, Helvetica, sans-serif; font-size: small; font-weight: bold; color: #000000; } .style4 {font-size: small; font-weight: bold; color: #FFFFFF; } .style5 {color: #FFFFFF} .style6 {color: #000000} --> </style> <style type="text/css"> .ds_box { background-color:#336633; border: 2px solid #666600; position: absolute; z-index: 32767; } .ds_tbl { background-color: #FFF; } .ds_head { background-color: #85A157; color: #FFF; font-family: Arial, Helvetica, sans-serif; font-size: 13px; font-weight: bold; text-align: center; letter-spacing: 2px; } .ds_subhead { background-color: #85A157; color: #000; font-size: 12px; font-weight: bold; text-align: center; font-family: Arial, Helvetica, sans-serif; width: 32px; } .ds_cell { background-color:#FFFFCC; color: #000; font-size: 13px; text-align: center; font-family: Arial, Helvetica, sans-serif; padding: 5px; cursor: pointer; border: 1px solid #666600; } .ds_cell:hover { background-color: #F3F3F3; } /* This hover code won't work for IE */ </style> <script src="SpryAssets/SpryValidationTextarea.js" type="text/javascript"></script> <link href="SpryAssets/SpryValidationTextarea.css" rel="stylesheet" type="text/css" /> </head> <body> <table class="ds_box" cellpadding="0" cellspacing="0" id="ds_conclass" style="display: none;"> <tr><td id="ds_calclass"> </td></tr> </table> <script type="text/javascript"> // <!-- <![CDATA[ // Project: Dynamic Date Selector (DtTvB) - 2006-03-16 // Script featured on JavaScript Kit- http://www.javascriptkit.com // Code begin... // Set the initial date. var ds_i_date = new Date(); ds_c_month = ds_i_date.getMonth() + 1; ds_c_year = ds_i_date.getFullYear(); // Get Element By Id function ds_getel(id) { return document.getElementById(id); } // Get the left and the top of the element. function ds_getleft(el) { var tmp = el.offsetLeft; el = el.offsetParent while(el) { tmp += el.offsetLeft; el = el.offsetParent; } return tmp; } function ds_gettop(el) { var tmp = el.offsetTop; el = el.offsetParent while(el) { tmp += el.offsetTop; el = el.offsetParent; } return tmp; } // Output Element var ds_oe = ds_getel('ds_calclass'); // Container var ds_ce = ds_getel('ds_conclass'); // Output Buffering var ds_ob = ''; function ds_ob_clean() { ds_ob = ''; } function ds_ob_flush() { ds_oe.innerHTML = ds_ob; ds_ob_clean(); } function ds_echo(t) { ds_ob += t; } var ds_element; // Text Element... var ds_monthnames = [ 'January', 'February', 'March', 'April', 'May', 'June', 'July', 'August', 'September', 'October', 'November', 'December' ]; // You can translate it for your language. var ds_daynames = [ 'Sun', 'Mon', 'Tue', 'Wed', 'Thu', 'Fri', 'Sat' ]; // You can translate it for your language. // Calendar template function ds_template_main_above(t) { return '<table cellpadding="3" cellspacing="1" class="ds_tbl">' + '<tr>' + '<td class="ds_head" style="cursor: pointer" onclick="ds_py();"><<</td>' + '<td class="ds_head" style="cursor: pointer" onclick="ds_pm();"><</td>' + '<td class="ds_head" style="cursor: pointer" onclick="ds_hi();" colspan="3">[Close]</td>' + '<td class="ds_head" style="cursor: pointer" onclick="ds_nm();">></td>' + '<td class="ds_head" style="cursor: pointer" onclick="ds_ny();">>></td>' + '</tr>' + '<tr>' + '<td colspan="7" class="ds_head">' + t + '</td>' + '</tr>' + '<tr>'; } function ds_template_day_row(t) { return '<td class="ds_subhead">' + t + '</td>'; // Define width in CSS, XHTML 1.0 Strict doesn't have width property for it. } function ds_template_new_week() { return '</tr><tr>'; } function ds_template_blank_cell(colspan) { return '<td colspan="' + colspan + '"></td>' } function ds_template_day(d, m, y) { return '<td class="ds_cell" onclick="ds_onclick(' + d + ',' + m + ',' + y + ')">' + d + '</td>'; // Define width the day row. } function ds_template_main_below() { return '</tr>' + '</table>'; } // This one draws calendar... function ds_draw_calendar(m, y) { // First clean the output buffer. ds_ob_clean(); // Here we go, do the header ds_echo (ds_template_main_above(ds_monthnames[m - 1] + ' ' + y)); for (i = 0; i < 7; i ++) { ds_echo (ds_template_day_row(ds_daynames[i])); } // Make a date object. var ds_dc_date = new Date(); ds_dc_date.setMonth(m - 1); ds_dc_date.setFullYear(y); ds_dc_date.setDate(1); if (m == 1 || m == 3 || m == 5 || m == 7 || m == 8 || m == 10 || m == 12) { days = 31; } else if (m == 4 || m == 6 || m == 9 || m == 11) { days = 30; } else { days = (y % 4 == 0) ? 29 : 28; } var first_day = ds_dc_date.getDay(); var first_loop = 1; // Start the first week ds_echo (ds_template_new_week()); // If sunday is not the first day of the month, make a blank cell... if (first_day != 0) { ds_echo (ds_template_blank_cell(first_day)); } var j = first_day; for (i = 0; i < days; i ++) { // Today is sunday, make a new week. // If this sunday is the first day of the month, // we've made a new row for you already. if (j == 0 && !first_loop) { // New week!! ds_echo (ds_template_new_week()); } // Make a row of that day! ds_echo (ds_template_day(i + 1, m, y)); // This is not first loop anymore... first_loop = 0; // What is the next day? j ++; j %= 7; } // Do the footer ds_echo (ds_template_main_below()); // And let's display.. ds_ob_flush(); // Scroll it into view. ds_ce.scrollIntoView(); } // A function to show the calendar. // When user click on the date, it will set the content of t. function ds_sh(t) { // Set the element to set... ds_element = t; // Make a new date, and set the current month and year. var ds_sh_date = new Date(); ds_c_month = ds_sh_date.getMonth() + 1; ds_c_year = ds_sh_date.getFullYear(); // Draw the calendar ds_draw_calendar(ds_c_month, ds_c_year); // To change the position properly, we must show it first. ds_ce.style.display = ''; // Move the calendar container! the_left = ds_getleft(t); the_top = ds_gettop(t) + t.offsetHeight; ds_ce.style.left = the_left + 'px'; ds_ce.style.top = the_top + 'px'; // Scroll it into view. ds_ce.scrollIntoView(); } // Hide the calendar. function ds_hi() { ds_ce.style.display = 'none'; } // Moves to the next month... function ds_nm() { // Increase the current month. ds_c_month ++; // We have passed December, let's go to the next year. // Increase the current year, and set the current month to January. if (ds_c_month > 12) { ds_c_month = 1; ds_c_year++; } // Redraw the calendar. ds_draw_calendar(ds_c_month, ds_c_year); } // Moves to the previous month... function ds_pm() { ds_c_month = ds_c_month - 1; // Can't use dash-dash here, it will make the page invalid. // We have passed January, let's go back to the previous year. // Decrease the current year, and set the current month to December. if (ds_c_month < 1) { ds_c_month = 12; ds_c_year = ds_c_year - 1; // Can't use dash-dash here, it will make the page invalid. } // Redraw the calendar. ds_draw_calendar(ds_c_month, ds_c_year); } // Moves to the next year... function ds_ny() { // Increase the current year. ds_c_year++; // Redraw the calendar. ds_draw_calendar(ds_c_month, ds_c_year); } // Moves to the previous year... function ds_py() { // Decrease the current year. ds_c_year = ds_c_year - 1; // Can't use dash-dash here, it will make the page invalid. // Redraw the calendar. ds_draw_calendar(ds_c_month, ds_c_year); } // Format the date to output. function ds_format_date(d, m, y) { // 2 digits month. m2 = '00' + m; m2 = m2.substr(m2.length - 2); // 2 digits day. d2 = '00' + d; d2 = d2.substr(d2.length - 2); // YYYY-MM-DD return y + '-' + m2 + '-' + d2; } // When the user clicks the day. function ds_onclick(d, m, y) { // Hide the calendar. ds_hi(); // Set the value of it, if we can. if (typeof(ds_element.value) != 'undefined') { ds_element.value = ds_format_date(d, m, y); // Maybe we want to set the HTML in it. } else if (typeof(ds_element.innerHTML) != 'undefined') { ds_element.innerHTML = ds_format_date(d, m, y); // I don't know how should we display it, just alert it to user. } else { alert (ds_format_date(d, m, y)); } } // And here is the end. // ]]> --> </script> </head> <body> <div id="container"> <?php include "Header.php"; ?> <div id="content"> <div id="left"> <h1>Welcome <?php echo $_SESSION['Name'];?></h1> <div id="TabbedPanels1" class="TabbedPanels"> <ul class="TabbedPanelsTabGroup"> <li class="TabbedPanelsTab style1" tabindex="0">Create QUIZ Schedule</li> <li class="TabbedPanelsTab style2 style3" tabindex="0">Display QUIZ Schedule</li> </ul> <div class="TabbedPanelsContentGroup"> <div class="TabbedPanelsContent"> <table width="100%" border="0" cellspacing="0" cellpadding="0"> <tr> <td> </td> </tr> <tr> <td><form id="form1" name="form1" method="POST" action="UpdateSchedule1.php"> <table width="100%" height="180" border="0" cellpadding="0" cellspacing="0"> <tr> <td>Select QUIZ:</td> <td><label> <select name="cmbExam" id="cmbExam"> <?php do { ?> <option value="<?php echo $row_Recordset1['Quiz_Id']?>"><?php echo $row_Recordset1['Quiz_Name']?></option> <?php } while ($row_Recordset1 = mysql_fetch_assoc($Recordset1)); $rows = mysql_num_rows($Recordset1); if($rows > 0) { mysql_data_seek($Recordset1, 0); $row_Recordset1 = mysql_fetch_assoc($Recordset1); } ?> </select> </label></td> </tr> <tr> <td height="32">Select Semester:</td> <td><label> <select name="cmbSem" id="cmbSem"> <option>1</option> <option>2</option> <option>3</option> <option>4</option> <option>5</option> <option>6</option> </select> </label></td> </tr> <tr> <td>Select Subject:</td> <td><label> <select name="cmbSubject" id="cmbSubject"> <?php do { ?> <option value="<?php echo $row_Recordset2['Subject_Id']?>"><?php echo $row_Recordset2['Subject_Name']?></option> <?php } while ($row_Recordset2 = mysql_fetch_assoc($Recordset2)); $rows = mysql_num_rows($Recordset2); if($rows > 0) { mysql_data_seek($Recordset2, 0); $row_Recordset2 = mysql_fetch_assoc($Recordset2); } ?> </select> </label></td> </tr> <tr> <td>Exam Date:<?php echo $Date=$row12['QuizDate']; ?></td> <td><span id="sprytextfield1"> <label> <input type="text" name="txtDate" id="txtDate" onclick="ds_sh(this);" value ="<?php echo $row12['QuizDate']; ?>"> </label> <span class="textfieldRequiredMsg">A value is required.</span></span></td> </tr> <tr> <td height="27">Exam Time:</td> <td><span id="sprytextfield2"> <label> <input type="text" name="txtTime" id="txtTime" value ="<?php echo $row12['QuizTime']; ?>"/> </label> <span class="textfieldRequiredMsg">A value is required.</span></span></td> </tr> <tr> <td> </td> <td><label> <input type="submit" name="button" id="button" value="Submit" /> </label></td> </tr> </table> </form> </td> </tr> </table> </div> <div class="TabbedPanelsContent"> <table width="100%" border="1" bordercolor="#85A157" > <tr> <th height="32" bgcolor="#85A157" class="style13"><div align="left" class="style9 style5"><strong>Id</strong></div></th> <th bgcolor="#85A157" class="style13"><div align="left" class="style9 style5"><strong>QUIZ Type</strong></div></th> <th bgcolor="#85A157" class="style13"><div align="left" class="style9 style5"><strong>Semester</strong></div></th> <th height="32" bgcolor="#85A157" class="style13"><div align="left" class="style9 style5"><strong>Subject</strong></div></th> <th bgcolor="#85A157" class="style13"><div align="left" class="style9 style5"><strong>Date</strong></div></th> <th bgcolor="#85A157" class="style13"><div align="left" class="style9 style5"><strong>Time</strong></div></th> <!----------------------------------------------------> <th bgcolor="#85A157" class="style13"><div align="left" class="style4">Update</div></th> <!----------------------------------------------------> </tr> <?php // Establish Connection with Database $con = mysql_connect("localhost","root"); // Select Database mysql_select_db("QUIZ", $con); // Specify the query to execute //new editing the data to............................................................................................................................................. // fetch the record all data........................ echo $sql = "SELECT quiz_schedule.Schedule_Id, quiz_schedule.Semester, quiz_schedule.QuizDate, quiz_schedule.QuizTime, quiz_category.Quiz_Name, subject_master.Subject_Name FROM quiz_schedule, quiz_category, subject_master WHERE quiz_schedule.Quiz_Id=quiz_category.Quiz_Id AND quiz_schedule.Subject_Id=subject_master.Subject_Id"; // end select the data all data................................................................................................................................... // update the record all data.............................. // Execute query $result = mysql_query($sql,$con); // Loop through each records while($row = mysql_fetch_array($result)) { $Id=$row['Schedule_Id']; $Quiz=$row['Quiz_Name']; $Sem=$row['Semester']; $Subject=$row['Subject_Name']; $Date=$row['QuizDate']; $Time=$row['QuizTime']; } ?> <?php echo $sql = "UPDATE quiz_schedule.Schedule_Id, quiz_schedule.Semester, quiz_schedule.QuizDate, quiz_schedule.QuizTime, quiz_category.Quiz_Name, subject_master.Subject_Name FROM quiz_schedule, quiz_category, subject_master SET QuizDate = '".$QuizDate."',QuizTime ='".$QuizTime."' where Schedule_Id='".$Id."'"; // Execute query $result = mysql_query($sql,$con); // Loop through each records while($row = mysql_fetch_array($result)) { $Id=$row['Schedule_Id']; $Quiz=$row['Quiz_Name']; $Sem=$row['Semester']; $Subject=$row['Subject_Name']; $Date=$row['QuizDate']; $Time=$row['QuizTime']; ?> <tr> <td class="style13"><div align="left" class="style9 style6"><strong><?php echo $Id;?></strong></div></td> <td class="style13"><div align="left" class="style9 style6"><strong><?php echo $Quiz;?></strong></div></td> <td class="style13"><div align="left" class="style9 style6"><strong><?php echo $Sem;?></strong></div></td> <td class="style13"><div align="left" class="style9 style6"><strong><?php echo $Subject;?></strong></div></td> <td class="style13"><div align="left" class="style9 style6"><strong><?php echo $Date;?></strong></div></td> <td class="style13"><div align="left" class="style9 style6"><strong><?php echo $Time;?></strong></div></td> <!--------------------------update schedule-------------------------> <td class="style13"><div align="left" class="style9 style6"><strong><a href="UpdateSchedule1.php?SchId=<?php echo $Id;?>">Update</a></strong></div></td> <!------------------------------------------------------> </tr> <?php } // Retrieve Number of records returned $records = mysql_num_rows($result); ?> <tr> <td colspan="7" class="style13"><div align="left" class="style12"> </div></td> </tr> <?php // Close the connection mysql_close($con); ?> </table> </div> </div> </div> <p> </p> <h1> </h1> </div> <div id="footerline"></div> </div> <div id="footer">Copyright © 2013 Online Quiz. All rights reserved.</div> </div> <script type="text/javascript"> <!-- var TabbedPanels1 = new Spry.Widget.TabbedPanels("TabbedPanels1"); var sprytextfield1 = new Spry.Widget.ValidationTextField("sprytextfield1"); var sprytextfield2 = new Spry.Widget.ValidationTextField("sprytextfield2"); //--> </script> </body> </html> <?php mysql_free_result($Recordset1); mysql_free_result($Recordset2); ?>
-
Answer:
The code is long, I didn't read everything. However, here are my observations. You haven't specified what error you are getting The code doesn't follow standards It is vulnerable to sql injection I suggest you to head over to http://www.phptherightway.com/ and refactor the script.
Prabhakar Bhat at Quora Visit the source
Related Q & A:
- What is error code 6 for Yahoo! mail?Best solution by in.answers.yahoo.com
- Why I keep getting an error messenger when i try to down load yahoo messenger though?Best solution by Yahoo! Answers
- Why do I get the error "A network error occured while connecting to the server?Best solution by Yahoo! Answers
- Why do I get an error message when I am trying to close Internet explorer page?Best solution by Yahoo! Answers
- Why do I get an error message when I open my address book?Best solution by Yahoo! Answers
Just Added Q & A:
- How many active mobile subscribers are there in China?Best solution by Quora
- How to find the right vacation?Best solution by bookit.com
- How To Make Your Own Primer?Best solution by thekrazycouponlady.com
- How do you get the domain & range?Best solution by ChaCha
- How do you open pop up blockers?Best solution by Yahoo! Answers
For every problem there is a solution! Proved by Solucija.
-
Got an issue and looking for advice?
-
Ask Solucija to search every corner of the Web for help.
-
Get workable solutions and helpful tips in a moment.
Just ask Solucija about an issue you face and immediately get a list of ready solutions, answers and tips from other Internet users. We always provide the most suitable and complete answer to your question at the top, along with a few good alternatives below.