how to call a function in Python in another function?

Which is the better practice of applying conditions to call a function: before the function call or inside the function?

• Let's say there is a function that receives a certain number of variables. If those variables are not ready, the task should not be performed. Which is better? doSomeTask( $a, $b, $c, $d ); function doSomeTask( $a, $b, $c, $d ) { if ( ! ( $a && $b && $c && $d ) ) { return; } // do something with $a, $b, $c, and $d. } if ( $a && $b && $c && $d ) { doSomeTask( $a, $b, $c, $d ); } function doSomeTask( $a, $b, $c, $d ) { // do something with $a, $b, $c, and $d. }

• Answer:

  It likely makes more sense inside the function since if you later call the function from other places, you'd start repeating the if check. Inside: function foo(a) { if (!a) { return; } bar; } foo(a); foo(a); Outside: function foo(a) { bar; } if (a) { foo(a); } … if (a) { foo(a); }