Places for great photos in South Wales?

http://www.museumwales.ac.uk/en/stfagans/ is a national heritage park. Historic buildings from various parts of Wales have either been moved to the park or had copies built using the appropriate materials and technologies. So they have everything from an Iron Age village and a (pre-Cromwell, therefore colourfully decorated) Normal style church, with various other buildings or settlements covering Welsh history up to the 1980s or thereabouts. Have a look at the website to see what days the blacksmith, cooper, flint knappers, etc. will be working. Some nice woods and a few styles of landscaped garden to wander around in too. You'll spend most of your time outdoors so it needs good weather, but there's a great range of architecture and scenery to play with. If you do go to St Fagans, consider popping up the road to Pentyrch, to see St Catwg's Church. Nothing too special on the inside, but it's a pretty church in a nice setting. The spire was designed by the architect who later designed a lot of the current structure of Llandaf Cathedral, and is recognisably the same style and quality. (Llandaf Cathedral is pretty good too, but its surroundings aren't great and if you've been in Anglican cathedrals before then the inside is nothing particularly special). Cardiff Bay has some nice architecture that might be worth a look. The Millennium Centre (opera house), national assembly building and Norwegian Church are particularly good, and all free entry IIRC. http://www.wales360.co.uk/castell_coch/ is small but pretty spectacular. It looks good from a distance too, poking out of the tree line on the side of the hill. It was built as a spectacle rather than a working castle, so there's not a great deal of history there. I agree with Blazecock Pileon that Caerphilly castle is well worth visiting if you want to see a "real" one. https://secure.wikimedia.org/wikipedia/en/wiki/Caerleon is a bit of a trek, but fantastic for Roman history if you're interested. The ampitheatre has survived quite well. The local roman history museum is excellent, and occasionally hold events in the ampitheatre over the summer. http://www.cosmeston.com/ is a large nature reserve (actually a SSSI), which is worth a visit. The area immediately around the lakes gets pretty busy on non-school days when the weather is good, but if you wonder deeper into the park -- into the woodland or over the marsh -- you can get away pretty easily. Next to the main park there's another rebuilt iron age village. It's good but expensive to get in, so if you're going to St Fagans I wouldn't bother with this one. Nearby, the sea front at Porthcawl can be quite dramatic if the tide is in and the wind is getting up. I think it's a nice looking town but from your profile I assume you're British so it's nothing you haven't seen before. Some of the clifftop paths running along the coast are pretty good, giving some good cliffs and nice views over the water. Gileston to Llantwit Major to St Donats is a nice one. If you're feeling energetic, keep going to the beach at Ogmore, which is a huge, flat sandy beach that could make for some nice photos.

The Gower Peninsula outside of Swansea. Especially Three Cliffs Bay.

http://www.thevalleys.co.uk/site/attractions/industrial-heritage has some suggestions of places to visit in the South Wales valleys under the heading of 'industrial heritage'. One in particular that could make for some striking pictures is the 'http://www.thevalleys.co.uk/site/attractions/guardian-six-bells-mining-memorial-p122031' memorial at Six Bells.

http://naturalhighs.net/waterfalls/falls00/ystradfellte.htm http://www.museumwales.ac.uk/en/bigpit/ http://www.barrywales.co.uk/hawkingcentre/ http://www.redkiteswales.co.uk/ http://www.museumwales.ac.uk/en/stfagans/ I don't live in Wales any more (sob!) but have a very helpful photographer father who can help with specifics, feel free to send a memail.

Snowdonia National Park!!! It is full of beautiful mountains, changing clouds that cast shadows on the mountains, and beautiful views. You can take a bus tour for one euro. It is where they train the rescue dogs in Wales and is a gorgeous place.

It is well-touristed, but Tintern Abbey (and surrounding area) are undeniably beautiful.

http://www.pembrokeshirecoast.org.uk/default.asp?PID=401

Get thee to the Gower. Cardiff to Swansea is your hour's drive: http://www.cadwevents.co.uk/monuments/neath-abbey-and-gatehouse and http://www.castlewales.com/oyster.html in the Mumbles provide some mediaeval architecture; misteraich's link is great for the industrial heritage, which is no less photogenic.

Someone I know goes to Wales and takes the most amazing photos of RAF planes from above as they fly nap-of-the-earth through the moutain passes. I will try to figure out where he stays.